lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 144/425] md: Fix missing unused status line of /proc/mdstat
    Date
    From: Jan Glauber <jglauber@digitalocean.com>

    commit 7abfabaf5f805f5171d133ce6af9b65ab766e76a upstream.

    Reading /proc/mdstat with a read buffer size that would not
    fit the unused status line in the first read will skip this
    line from the output.

    So 'dd if=/proc/mdstat bs=64 2>/dev/null' will not print something
    like: unused devices: <none>

    Don't return NULL immediately in start() for v=2 but call
    show() once to print the status line also for multiple reads.

    Cc: stable@vger.kernel.org
    Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface")
    Signed-off-by: Jan Glauber <jglauber@digitalocean.com>
    Signed-off-by: Song Liu <songliubraving@fb.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/md/md.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -7814,7 +7814,11 @@ static void *md_seq_start(struct seq_fil
    loff_t l = *pos;
    struct mddev *mddev;

    - if (l >= 0x10000)
    + if (l == 0x10000) {
    + ++*pos;
    + return (void *)2;
    + }
    + if (l > 0x10000)
    return NULL;
    if (!l--)
    /* header */

    \
     
     \ /
      Last update: 2021-05-20 11:51    [W:4.187 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site