lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 108/425] usb: gadget: Fix double free of device descriptor pointers
    Date
    From: Hemant Kumar <hemantk@codeaurora.org>

    commit 43c4cab006f55b6ca549dd1214e22f5965a8675f upstream.

    Upon driver unbind usb_free_all_descriptors() function frees all
    speed descriptor pointers without setting them to NULL. In case
    gadget speed changes (i.e from super speed plus to super speed)
    after driver unbind only upto super speed descriptor pointers get
    populated. Super speed plus desc still holds the stale (already
    freed) pointer. Fix this issue by setting all descriptor pointers
    to NULL after freeing them in usb_free_all_descriptors().

    Fixes: f5c61225cf29 ("usb: gadget: Update function for SuperSpeedPlus")
    cc: stable@vger.kernel.org
    Reviewed-by: Peter Chen <peter.chen@kernel.org>
    Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
    Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
    Link: https://lore.kernel.org/r/1619034452-17334-1-git-send-email-wcheng@codeaurora.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/config.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/gadget/config.c
    +++ b/drivers/usb/gadget/config.c
    @@ -194,9 +194,13 @@ EXPORT_SYMBOL_GPL(usb_assign_descriptors
    void usb_free_all_descriptors(struct usb_function *f)
    {
    usb_free_descriptors(f->fs_descriptors);
    + f->fs_descriptors = NULL;
    usb_free_descriptors(f->hs_descriptors);
    + f->hs_descriptors = NULL;
    usb_free_descriptors(f->ss_descriptors);
    + f->ss_descriptors = NULL;
    usb_free_descriptors(f->ssp_descriptors);
    + f->ssp_descriptors = NULL;
    }
    EXPORT_SYMBOL_GPL(usb_free_all_descriptors);


    \
     
     \ /
      Last update: 2021-05-20 11:49    [W:3.464 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site