lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] bcache: avoid oversized read request in cache missing code path
From
Date
On 5/20/21 4:05 PM, Christoph Hellwig wrote:
> This fix is pretty gross. Adding pages to bios can fail for all kinds
> of reasons, so the fix is to use bio_add_page and check its return
> value, and if it needs another bio keep looping and chaining more bios.
>

OK, I will try this idea and avoid to access BIO_MAX_VECS directly.

> And maybe capping the readahead to some sane upper bound still makes
> sense, but it should never look at BIO_MAX_VECS for that.
>

Thanks for the hint.

Coly Li

\
 
 \ /
  Last update: 2021-05-21 05:30    [W:0.045 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site