lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments
    From
    Date

    Hi Johan,

    On 2021/5/20 21:52, Johan Hovold wrote:
    > On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote:
    >
    >>> Checkpatch already has too many checks IMO and I'm a bit surprised that
    >>> it doesn't check this already. Perhaps it's because you used the -f to
    >>> run checkpatch on in-kernel code, which you should not.
    >>>
    >>>>> Second, that sentence is not capitalised so why do add a period?
    >>>>>
    >>>>
    >>>> How about capitalize the sentence, or just remove the period ?
    >>>
    >>> How about just leaving this unchanged?
    >>
    >> OK
    >> And I will keep the patch 8/9, and combine space issues into
    >> one new patch, and remove the others.
    >
    > Yeah, 8/9 is arguably a fix even if it's for a very minor issue
    > (repeated words in a comment).
    >
    > It doesn't look like any of the white space issues are worth fixing,
    > though. Such pedantry can usually be addressed when the code in question
    > is being modified for other reasons.
    >

    OK, it is reasonable. thanks.

    > Johan
    >
    > .
    >

    \
     
     \ /
      Last update: 2021-05-21 04:24    [W:2.729 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site