Messages in this thread | | | Subject | Re: [PATCH Part1 RFC v2 10/20] x86/sev: Add a helper for the PVALIDATE instruction | From | Brijesh Singh <> | Date | Thu, 20 May 2021 12:57:43 -0500 |
| |
On 5/20/21 12:51 PM, Borislav Petkov wrote: > On Thu, May 20, 2021 at 12:44:50PM -0500, Brijesh Singh wrote: >> Hmm, I use the SIZEMISMATCH later in the patches. > You do, where? Maybe I don't see it.
Sorry, my bad. Currently all the pages are pre-validated, and guest kernel uses 4K in the page state change VMGEXIT. So, we should *not* see the SIZEMISMATCH. This will happen when we move to lazy validation. I mixed up with OVMF in which I validate pages as a large. I will drop the macro.
> >> Since I was introducing the pvalidate in separate patch so decided to >> define all the return code. > You can define them in a comment so that it is clear what PVALIDATE > returns but not as defines when they're unused.
Got it.
> > Thx. >
| |