Messages in this thread | | | Date | Thu, 20 May 2021 18:07:47 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH 2/2] mtd: partitions: redboot: fix style issues |
| |
Linus Walleij <linus.walleij@linaro.org> wrote on Thu, 20 May 2021 18:00:04 +0200:
> On Thu, May 20, 2021 at 5:36 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Linus Walleij <linus.walleij@linaro.org> wrote on Thu, 20 May 2021 > > 17:24:26 +0200: > > > On Thu, May 20, 2021 at 1:49 PM Corentin Labbe <clabbe@baylibre.com> wrote: > > > > > > > This patch fixes easy checkpatch issues. > > > > > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > > (...) > > > > - uint32_t flash_base; // Address within FLASH of image > > > (...) > > > > + u32 flash_base; // Address within FLASH of image > > > > > > Does checkpatch complain about this? At one point the MTD maintainer > > > disliked the u32/u16/u8 types and explicitly wanted to use the C > > > standard library types, and it's the kind of eccentric maintainer > > > deviations we accommodate for. > > > > I suppose this happened quite some time ago? :) > > > > I've never heard Richard nor Boris complaining about it, nor will I. > > Yes that was a specific David Woodhouse preference. > I'm too old!
Don't be sad, the new trend is to be sleek. In the dark I worship variables declaration in a reverse Christmas tree order ;-)
| |