lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/6] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node errors
From
Date
Hi Rob,

On 19/05/21 4:58 am, Rob Herring wrote:
> The ti,j721e-system-controller binding does not follow the standard mux
> controller node name 'mux-controller' and the example is incomplete. Fix
> these to avoid schema errors before the mux controller binding is
> converted to schema.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../mfd/ti,j721e-system-controller.yaml | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> index 19fcf59fd2fe..272832e9f8f2 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
> @@ -43,12 +43,10 @@ properties:
>
> patternProperties:
> # Optional children
> - "^serdes-ln-ctrl@[0-9a-f]+$":
> + "^mux-controller@[0-9a-f]+$":
> type: object
> - description: |
> - This is the SERDES lane control mux. It should follow the bindings
> - specified in
> - Documentation/devicetree/bindings/mux/reg-mux.txt
> + description:
> + This is the SERDES lane control mux.
>
> required:
> - compatible
> @@ -68,9 +66,18 @@ examples:
> #size-cells = <1>;
> ranges;
>
> - serdes_ln_ctrl: serdes-ln-ctrl@4080 {
> + serdes_ln_ctrl: mux-controller@4080 {
> compatible = "mmio-mux";
> reg = <0x00004080 0x50>;

"mmio-mux" compatible doesn't define using "reg" property. But a system
can have multiple mux-controllers which would require us to use
mux-controller@0, mux-controller@1,..

And IIRC if we have "@", 'reg' will be a required required property.
Would it be an issue here?

Thanks
Kishon

\
 
 \ /
  Last update: 2021-05-20 16:44    [W:0.141 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site