lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 098/190] media: omap4iss: return error code when omap4iss_get() failed
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 8938c48fa25b491842ece9eb38f0bea0fcbaca44 ]

    If omap4iss_get() failed, it need return error code in iss_probe().

    Fixes: 59f0ad807681 ("[media] v4l: omap4iss: Add support for OMAP4...")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/omap4iss/iss.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
    index aa76ccda5b42..130d09d28e1d 100644
    --- a/drivers/staging/media/omap4iss/iss.c
    +++ b/drivers/staging/media/omap4iss/iss.c
    @@ -1406,8 +1406,10 @@ static int iss_probe(struct platform_device *pdev)
    if (ret < 0)
    goto error;

    - if (!omap4iss_get(iss))
    + if (!omap4iss_get(iss)) {
    + ret = -EINVAL;
    goto error;
    + }

    ret = iss_reset(iss);
    if (ret < 0)
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-20 13:36    [W:7.993 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site