Messages in this thread |  | | Date | Sun, 2 May 2021 15:53:46 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH v7 1/6] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding |
| |
On Fri 30 Apr 15:05 CDT 2021, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml [..] > > + qcom,power-source: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + power-source used to drive the output, as defined in the datasheet. > > + Should be specified if the TRILED block is present > > constraints? >
Yes, we should be able to constrain this a little bit.
> > + > > + qcom,dtest: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: > > > + A list of integer pairs, where each pair represent the dtest line the > > + particular channel should be connected to and the flags denoting how the > > + value should be outputed, as defined in the datasheet. The number of > > + pairs should be the same as the number of channels. > > Sounds like a matrix rather than array. Constraints on the values? >
I wasn't aware of uint32-matrix and that I can describe the constraints of the values in the matrix. I'll familiarize myself with it and see if I can tighten this up a little bit.
Thanks, Bjorn
|  |