Messages in this thread | | | From | Alexandre Courbot <> | Date | Wed, 19 May 2021 14:23:25 +0900 | Subject | Re: [PATCH v4 07/15] media: mtk-vcodec: vdec: add media device if using stateless api |
| |
On Mon, May 17, 2021 at 1:35 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Tue, Apr 27, 2021 at 7:16 PM Alexandre Courbot <acourbot@chromium.org> wrote: > > > > From: Yunfei Dong <yunfei.dong@mediatek.com> > > > > The stateless API requires a media device for issuing requests. Add one > > if we are being instantiated as a stateless decoder. > > > > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com> > > [acourbot: refactor, cleanup and split] > > Co-developed-by: Alexandre Courbot <acourbot@chromium.org> > > Signed-off-by: Alexandre Courbot <acourbot@chromium.org> > > --- > > drivers/media/platform/Kconfig | 1 + > > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 39 +++++++++++++++++++ > > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 2 + > > 3 files changed, 42 insertions(+) > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index ae1468aa1b4e..4154fdec2efb 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -315,6 +315,7 @@ config VIDEO_MEDIATEK_VCODEC > > select VIDEO_MEDIATEK_VCODEC_VPU if VIDEO_MEDIATEK_VPU > > select VIDEO_MEDIATEK_VCODEC_SCP if MTK_SCP > > select V4L2_H264 > > + select MEDIA_CONTROLLER > > Should this also select MEDIA_CONTROLLER_REQUEST_API config?
Yup, it probably should. hantro and rkvdec also select it, so let's do the same.
Thanks! Alex.
| |