lkml.org 
[lkml]   [2021]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 12/14] d_path: prepend_path(): lift the inner loop into a new helper
    On Wed, May 19, 2021 at 12:48:59AM +0000, Al Viro wrote:
    > ... and leave the rename_lock/mount_lock handling in prepend_path()
    > itself

    ...

    > + if (!IS_ERR_OR_NULL(mnt_ns) && !is_anon_ns(mnt_ns))
    > + return 1; // absolute root
    > + else
    > + return 2; // detached or not attached yet

    Would it be slightly better to read

    if (IS_ERR_OR_NULL(mnt_ns) || is_anon_ns(mnt_ns))
    return 2; // detached or not attached yet
    else
    return 1; // absolute root

    ?

    Oh, I have noticed that it's in the original piece of code (perhaps separate
    change if we ever need it?).


    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2021-05-19 10:07    [W:2.707 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site