Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch 5/8] perf/arm-dsu: Use irq_set_affinity() | Date | Tue, 18 May 2021 17:50:40 +0200 |
| |
On Tue, May 18 2021 at 12:31, John Garry wrote: > On 18/05/2021 10:17, Thomas Gleixner wrote: >> >> @@ -769,7 +769,6 @@ static int dsu_pmu_device_probe(struct p >> if (rc) { > > nit: I think that someone will send a patch to remove these {} later... > >> cpuhp_state_remove_instance(dsu_pmu_cpuhp_state, >> &dsu_pmu->cpuhp_node); >> - irq_set_affinity_hint(dsu_pmu->irq, NULL); >> }
which should be rejected because
cpuhp_state_remove_instance(dsu_pmu_cpuhp_state, &dsu_pmu->cpuhp_node);
is _NOT_ a one line statement.
if (foo) cpuhp_state_remove_instance(state, &node);
is fine, but
if (foo) cpuhp_state_remove_instance(dsu_pmu_cpuhp_state, &dsu_pmu->cpuhp_node);
breaks the expectation of a single line following the condition which confuses my brain based OCR. :)
So I left the brackets there on purpose.
Thanks,
tglx
| |