Messages in this thread | | | Subject | Re: [PATCH v2 09/17] crypto: qce: core: Add support to initialize interconnect path | From | Thara Gopinath <> | Date | Tue, 18 May 2021 11:38:08 -0400 |
| |
On 5/18/21 11:07 AM, Bjorn Andersson wrote: > On Wed 05 May 16:37 CDT 2021, Bhupesh Sharma wrote: > >> From: Thara Gopinath <thara.gopinath@linaro.org> >> >> Crypto engine on certain Snapdragon processors like sm8150, sm8250, sm8350 >> etc. requires interconnect path between the engine and memory to be >> explicitly enabled and bandwidth set prior to any operations. Add support >> in the qce core to enable the interconnect path appropriately. >> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Andy Gross <agross@kernel.org> >> Cc: Herbert Xu <herbert@gondor.apana.org.au> >> Cc: David S. Miller <davem@davemloft.net> >> Cc: Stephen Boyd <sboyd@kernel.org> >> Cc: Michael Turquette <mturquette@baylibre.com> >> Cc: Vinod Koul <vkoul@kernel.org> >> Cc: dmaengine@vger.kernel.org >> Cc: linux-clk@vger.kernel.org >> Cc: linux-crypto@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: bhupesh.linux@gmail.com >> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> >> [Make header file inclusion alphabetical] >> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org> > > This says that you prepared the patch, then Thara picked up the patch > and sorted the includes. But somehow you then sent the patch. > > I.e. you name should be the last - unless you jointly wrote the path, in > which case you should also add a "Co-developed-by: Thara". > >> --- >> drivers/crypto/qce/core.c | 35 ++++++++++++++++++++++++++++------- >> drivers/crypto/qce/core.h | 1 + >> 2 files changed, 29 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c >> index 80b75085c265..92a0ff1d357e 100644 >> --- a/drivers/crypto/qce/core.c >> +++ b/drivers/crypto/qce/core.c >> @@ -5,6 +5,7 @@ >> >> #include <linux/clk.h> >> #include <linux/dma-mapping.h> >> +#include <linux/interconnect.h> >> #include <linux/interrupt.h> >> #include <linux/module.h> >> #include <linux/mod_devicetable.h> >> @@ -21,6 +22,8 @@ >> #define QCE_MAJOR_VERSION5 0x05 >> #define QCE_QUEUE_LENGTH 1 >> >> +#define QCE_DEFAULT_MEM_BANDWIDTH 393600 > > Do we know what this rate is? > >> + >> static const struct qce_algo_ops *qce_ops[] = { >> #ifdef CONFIG_CRYPTO_DEV_QCE_SKCIPHER >> &skcipher_ops, >> @@ -202,21 +205,35 @@ static int qce_crypto_probe(struct platform_device *pdev) >> if (ret < 0) >> return ret; >> >> + qce->mem_path = of_icc_get(qce->dev, "memory"); > > Using devm_of_icc_get() would save you some changes to the error path.
Right. I keep forgetting to use the devm_ version! Bhupesh, will you do these changes or do you want me to ?
-- Warm Regards Thara
| |