Messages in this thread | | | From | Peter Geis <> | Date | Tue, 18 May 2021 20:20:03 -0400 | Subject | Re: [PATCH] net: phy: add driver for Motorcomm yt8511 phy |
| |
On Tue, May 18, 2021 at 4:59 AM Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, May 11, 2021 at 05:46:06PM -0400, Peter Geis wrote: > > Add a driver for the Motorcomm yt8511 phy that will be used in the > > production Pine64 rk3566-quartz64 development board. > > It supports gigabit transfer speeds, rgmii, and 125mhz clk output. > > > > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > > --- > > MAINTAINERS | 6 +++ > > drivers/net/phy/Kconfig | 6 +++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/phy/motorcomm.c | 85 +++++++++++++++++++++++++++++++++++++ > > 4 files changed, 98 insertions(+) > > create mode 100644 drivers/net/phy/motorcomm.c > > <...> > > > +static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = { > > + { PHY_ID_MATCH_EXACT(PHY_ID_YT8511) }, > > + { /* sentinal */ } > > +} > > Why is this "__maybe_unused"? This *.c file doesn't have any compilation option > to compile part of it. > > The "__maybe_unused" is not needed in this case.
I was simply following convention, for example the realtek.c, micrel.c, and smsc.c drivers all have this as well.
> > Thanks
| |