Messages in this thread | | | From | Desmond Cheong Zhi Xi <> | Subject | Re: [PATCH 7/7] Staging: rtl8723bs: fix block comment in HalBtc8723b1Ant.c | Date | Tue, 18 May 2021 00:00:19 -0400 |
| |
On 17/5/21 6:13 am, Dan Carpenter wrote: > On Sun, May 16, 2021 at 08:29:27AM -0400, Desmond Cheong Zhi Xi wrote: >> This commit fixes the following checkpatch.pl warning: >> >> WARNING: Block comments use * on subsequent lines >> + /* >> + CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \ >> >> Signed-off-by: Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com> >> --- >> drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c >> index cc7f558903ac..87156b2cd1f0 100644 >> --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c >> +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c >> @@ -2511,10 +2511,10 @@ void EXhalbtc8723b1ant_DisplayCoexInfo(struct btc_coexist *pBtCoexist) >> CL_PRINTF(cliBuf); >> >> /* >> - CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", \ >> - pCoexDm->errorCondition); >> - CL_PRINTF(cliBuf); >> - */ >> + *CL_SPRINTF(cliBuf, BT_TMP_BUF_SIZE, "\r\n %-35s = 0x%x ", "Latest error condition(should be 0)", >> + * pCoexDm->errorCondition); >> + *CL_PRINTF(cliBuf); >> + */ >> } > > Always just delete dead code. Otherwise the patchset seems good. > > regards, > dan carpenter >
Thanks for the feedback, Dan. I'll remove the dead code in a v2 patchset.
Best wishes, Desmond
| |