Messages in this thread | | | Subject | Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang | From | "Gustavo A. R. Silva" <> | Date | Mon, 17 May 2021 20:09:05 -0500 |
| |
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks -- Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/21/21 09:51, Xue, Ying wrote: > This patch looks good to me. > > -----Original Message----- > From: Gustavo A. R. Silva <gustavoars@kernel.org> > Sent: Friday, March 5, 2021 5:25 PM > To: Jon Maloy <jmaloy@redhat.com>; Xue, Ying <Ying.Xue@windriver.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org> > Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>; linux-hardening@vger.kernel.org > Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > net/tipc/link.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644 > --- a/net/tipc/link.c > +++ b/net/tipc/link.c > @@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt) > break; > case LINK_FAILOVER_BEGIN_EVT: > l->state = LINK_FAILINGOVER; > + break; > case LINK_FAILURE_EVT: > case LINK_RESET_EVT: > case LINK_ESTABLISH_EVT: > -- > 2.27.0 >
| |