Messages in this thread | | | Subject | Re: [PATCH RESEND][next] ide: Fix fall-through warnings for Clang | From | "Gustavo A. R. Silva" <> | Date | Mon, 17 May 2021 19:54:45 -0500 |
| |
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks -- Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:11, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 04:00, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a break statement instead of letting the code fall >> through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/ide/siimage.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c >> index 198847488cc6..c190dc6dfb50 100644 >> --- a/drivers/ide/siimage.c >> +++ b/drivers/ide/siimage.c >> @@ -493,6 +493,7 @@ static int init_chipset_siimage(struct pci_dev *dev) >> case 0x30: >> /* Clocking is disabled, attempt to force 133MHz clocking. */ >> sil_iowrite8(dev, tmp & ~0x20, scsc_addr); >> + break; >> case 0x10: >> /* On 133Mhz clocking. */ >> break; >>
| |