lkml.org 
[lkml]   [2021]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c
From
Date
On 5/16/21 9:58 PM, Yang Yingliang wrote:
> Fix the following make W=1 kernel build warnings:
>
> drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
> drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Hi,
In kernel-doc notation, a function name should be followed by a '-',
not a ':'. Please fix & resend.

Thanks.

> ---
> drivers/rtc/rtc-m41t80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 89128fc29ccc..79512d1c828e 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c
> @@ -802,7 +802,7 @@ static int wdt_open(struct inode *inode, struct file *file)
> }
>
> /**
> - * wdt_close:
> + * wdt_release:
> * @inode: inode to board
> * @file: file handle to board
> *
> @@ -815,7 +815,7 @@ static int wdt_release(struct inode *inode, struct file *file)
> }
>
> /**
> - * notify_sys:
> + * wdt_notify_sys:
> * @this: our notifier block
> * @code: the event being reported
> * @unused: unused
>


--
~Randy

\
 
 \ /
  Last update: 2021-05-17 07:08    [W:0.032 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site