lkml.org 
[lkml]   [2021]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 140/289] scsi: qla2xxx: Prevent PRLI in target mode
    Date
    From: Anastasia Kovaleva <a.kovaleva@yadro.com>

    [ Upstream commit fcb16d9a8ecf1e9bfced0fc654ea4e2caa7517f4 ]

    In a case when the initiator in P2P mode by some circumstances does not
    send PRLI, the target, in a case when the target port's WWPN is less than
    initiator's, changes the discovery state in DSC_GNL. When gnl completes it
    sends PRLI to the initiator.

    Usually the initiator in P2P mode always sends PRLI. We caught this issue
    on Linux stable v5.4.6 https://www.spinics.net/lists/stable/msg458515.html.

    Fix this particular corner case in the behaviour of the P2P mod target
    login state machine.

    Link: https://lore.kernel.org/r/20210422153414.4022-1-a.kovaleva@yadro.com
    Fixes: a9ed06d4e640 ("scsi: qla2xxx: Allow PLOGI in target mode")
    Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Anastasia Kovaleva <a.kovaleva@yadro.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_init.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
    index 52e8b555bd1d..6faf34fa6220 100644
    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -1190,6 +1190,9 @@ static int qla24xx_post_prli_work(struct scsi_qla_host *vha, fc_port_t *fcport)
    {
    struct qla_work_evt *e;

    + if (vha->host->active_mode == MODE_TARGET)
    + return QLA_FUNCTION_FAILED;
    +
    e = qla2x00_alloc_work(vha, QLA_EVT_PRLI);
    if (!e)
    return QLA_FUNCTION_FAILED;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-17 17:46    [W:4.064 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site