Messages in this thread |  | | From | Geert Uytterhoeven <> | Date | Sun, 16 May 2021 11:04:15 +0200 | Subject | Re: [RFC 13/13] [net-next] 8390: xsurf100: avoid including lib8390.c |
| |
On Sun, May 16, 2021 at 6:24 AM Finn Thain <fthain@telegraphics.com.au> wrote: > On Sun, 16 May 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > > > This driver always warns about unused functions because it includes > > an file that it doesn't actually need: > > I don't think you can omit #include "lib8390.c" here without changing > driver behaviour, because of the macros in effect. > > I think this change would need some actual testing unless you can show > that the module binary does not change.
Michael posted a similar but different patch a while ago, involving calling ax_NS8390_reinit(): https://lore.kernel.org/linux-m68k/1528604559-972-3-git-send-email-schmitzmic@gmail.com/
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |