Messages in this thread |  | | From | Lukas Bulwahn <> | Date | Sun, 16 May 2021 10:49:21 +0200 | Subject | Re: [PATCH] checkpatch: Print some info if no filenames are given |
| |
On Sat, May 15, 2021 at 6:26 AM Joe Perches <joe@perches.com> wrote: > > On Sat, 2021-05-15 at 12:15 +0800, Tiezhu Yang wrote: > > After commit 45107ff6d526 ("checkpatch: if no filenames then read stdin"), > > if no filenames are given, it will read patch from stdin rather than exit > > directly, it is better to print some info about what to do next, otherwise > > it is a bit confusing whether the script hangs. > > I think this is unnecessary. > It's like trying to make cat without command line arguments emit something. >
Tiezhu, if you think this behaviour of checkpatch needs a description and explanation that the informed users* of checkpatch would value, you may submit a patch to the kernel's checkpatch documentation, ./Documentation/dev-tools/checkpatch.rst (or to see a rendered version, e.g., https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html). You might want to add a few example invocations of checkpatch and then explain with an example that checkpatch consumes stdin, if no patch file is given as argument.
Looking forward to your patch to the documentation...
*informed user = "somebody that actually reads the available kernel documentation on checkpatch"
Lukas
|  |