lkml.org 
[lkml]   [2021]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/4] x86/syscall: sign-extend system calls on entry to int

* H. Peter Anvin <hpa@zytor.com> wrote:

> This is an ABI change, but is in fact a revert to the original x86-64
> ABI. The original assembly entry code would zero-extend the system
> call number; this patch uses sign extend to be explicit that this is
> treated as a signed number (although in practice it makes no
> difference, of course) and to avoid people getting the idea of
> "optimizing" it, as has happened on at least two(!) separate
> occasions.

The original x86-64 ABI as documented by AMD, as we (probably) never had
this in Linux, right?

Sounds sensible to do this, assuming nothing relies on the weirdness.

Thanks,

Ingo

\
 
 \ /
  Last update: 2021-05-16 09:48    [W:0.186 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site