Messages in this thread Patch in this message |  | | From | Martin Kaiser <> | Subject | [PATCH 5/6] staging: rtl8188eu: use safe iterator in rtw_sta_flush | Date | Sun, 16 May 2021 18:06:12 +0200 |
| |
Use list_for_each_safe, we may delete list items while iterating over the list.
Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- compile-tested only
drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c index 601974df4114..8ffafc7eb316 100644 --- a/drivers/staging/rtl8188eu/core/rtw_ap.c +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c @@ -1579,7 +1579,7 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta, int rtw_sta_flush(struct adapter *padapter) { - struct list_head *phead, *plist; + struct list_head *phead, *plist, *temp; struct sta_info *psta = NULL; struct sta_priv *pstapriv = &padapter->stapriv; struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; @@ -1594,7 +1594,7 @@ int rtw_sta_flush(struct adapter *padapter) spin_lock_bh(&pstapriv->asoc_list_lock); phead = &pstapriv->asoc_list; /* free sta asoc_queue */ - list_for_each(plist, phead) { + list_for_each_safe(plist, temp, phead) { psta = list_entry(plist, struct sta_info, asoc_list); list_del_init(&psta->asoc_list); -- 2.20.1
|  |