lkml.org 
[lkml]   [2021]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: Print some info if no filenames are given
From
Date
On Sat, 2021-05-15 at 12:15 +0800, Tiezhu Yang wrote:
> After commit 45107ff6d526 ("checkpatch: if no filenames then read stdin"),
> if no filenames are given, it will read patch from stdin rather than exit
> directly, it is better to print some info about what to do next, otherwise
> it is a bit confusing whether the script hangs.

I think this is unnecessary.
It's like trying to make cat without command line arguments emit something.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -361,6 +361,8 @@ if ($^V && $^V lt $minimum_perl_version) {
>  
>
>  #if no filenames are given, push '-' to read patch from stdin
>  if ($#ARGV < 0) {
> + print "$P: missing patchfile or -f file\n";
> + print "Use --help if necessary or read patch from stdin\n";
>   push(@ARGV, '-');
>  }
>  
>


\
 
 \ /
  Last update: 2021-05-15 06:27    [W:0.063 / U:2.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site