Messages in this thread Patch in this message |  | | From | Zhen Lei <> | Subject | [PATCH 1/1] memory: pl353: Fix error return code in pl353_smc_probe() | Date | Sat, 15 May 2021 12:00:04 +0800 |
| |
When no child nodes are matched, an appropriate error code -ENODEV should be returned. However, we currently do not explicitly assign this error code to 'err'. As a result, 0 was incorrectly returned.
Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/memory/pl353-smc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c index 9c0a2841677739f..b0b251bb207f3a6 100644 --- a/drivers/memory/pl353-smc.c +++ b/drivers/memory/pl353-smc.c @@ -407,6 +407,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id) break; } if (!match) { + err = -ENODEV; dev_err(&adev->dev, "no matching children\n"); goto out_clk_disable; } -- 2.26.0.106.g9fadedd
|  |