Messages in this thread |  | | Subject | Re: [PATCH 1/1] drm/msm: Fix error return code in msm_drm_init() | From | Dmitry Baryshkov <> | Date | Sat, 15 May 2021 20:41:40 +0300 |
| |
On 08/05/2021 05:28, Zhen Lei wrote: > Fix to return a negative error code from the error handling case instead > of 0, as done elsewhere in this function. > > Fixes: 7f9743abaa79 ("drm/msm: validate display and event threads") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index e1104d2454e2..ebd856dde1f1 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -523,6 +523,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > priv->event_thread[i].worker = kthread_create_worker(0, > "crtc_event:%d", priv->event_thread[i].crtc_id); > if (IS_ERR(priv->event_thread[i].worker)) { > + ret = PTR_ERR(priv->event_thread[i].worker); > DRM_DEV_ERROR(dev, "failed to create crtc_event kthread\n"); > goto err_msm_uninit; > } >
-- With best wishes Dmitry
|  |