lkml.org 
[lkml]   [2021]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback
On Sat, 15 May 2021, Tetsuo Handa wrote:

> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 3406067985b1..22bb3892f6bd 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2019,7 +2019,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
> return -EINVAL;
>
> pr_debug("resize now %ix%i\n", var.xres, var.yres);
> - if (con_is_visible(vc)) {
> + if (con_is_visible(vc) && vc->vc_mode == KD_TEXT) {
> var.activate = FB_ACTIVATE_NOW |
> FB_ACTIVATE_FORCE;
> fb_set_var(info, &var);

LGTM, although I'll yet try to verify it with hardware. But it'll have
to wait another week or so as I'm currently away from my lab and this
requires physical presence.

Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>

Maciej

\
 
 \ /
  Last update: 2021-05-15 18:23    [W:0.127 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site