lkml.org 
[lkml]   [2021]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 26/94] Maple Tree: Add new data structure
    Date
    * Peter Zijlstra <peterz@infradead.org> [210514 07:55]:
    > On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote:
    > > +static inline void mas_set_range(struct ma_state *mas, unsigned long start,
    > > + unsigned long last)
    > > +{
    > > + mas->index = start;
    > > + mas->last = last;
    > > + mas->node = MAS_START;
    > > +}
    >
    > Your indenting went wobbly :-)
    >
    > Also, I personally prefer this style:
    >
    > static inline void
    > mas_set_range(struct ma_state *mas, unsigned long start, unsigned long last)
    > {
    > mas->index = start;
    > mas->last = last;
    > mas->node = MAS_START;
    > }
    >
    > And I'm a big proponent of at the very least keeping line-breaks aligned
    > to '(', like:
    >
    > static inline void mas_set_range(struct ma_state *mas, unsigned long start,
    > unsigned long last)
    > {
    > mas->index = start;
    > mas->last = last;
    > mas->node = MAS_START;
    > }
    >
    > Which you can get vim to do by using: set cino=(0:0
    >
    >
    >


    Thanks, I will fix this.
    \
     
     \ /
      Last update: 2021-05-14 23:27    [W:4.433 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site