Messages in this thread | | | From | Liam Howlett <> | Subject | Re: [PATCH 26/94] Maple Tree: Add new data structure | Date | Fri, 14 May 2021 21:25:06 +0000 |
| |
* Peter Zijlstra <peterz@infradead.org> [210514 07:55]: > On Wed, Apr 28, 2021 at 03:36:02PM +0000, Liam Howlett wrote: > > +static inline void mas_set_range(struct ma_state *mas, unsigned long start, > > + unsigned long last) > > +{ > > + mas->index = start; > > + mas->last = last; > > + mas->node = MAS_START; > > +} > > Your indenting went wobbly :-) > > Also, I personally prefer this style: > > static inline void > mas_set_range(struct ma_state *mas, unsigned long start, unsigned long last) > { > mas->index = start; > mas->last = last; > mas->node = MAS_START; > } > > And I'm a big proponent of at the very least keeping line-breaks aligned > to '(', like: > > static inline void mas_set_range(struct ma_state *mas, unsigned long start, > unsigned long last) > { > mas->index = start; > mas->last = last; > mas->node = MAS_START; > } > > Which you can get vim to do by using: set cino=(0:0 > > >
Thanks, I will fix this.
| |