lkml.org 
[lkml]   [2021]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V6 00/10] PKS: Add Protection Key Supervisor support
On Fri, Apr 16, 2021 at 03:14:56PM -0700, 'Ira Weiny' wrote:
> On Thu, Apr 01, 2021 at 03:58:23PM -0700, 'Ira Weiny' wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > Introduce a new page protection mechanism for supervisor pages, Protection Key
> > Supervisor (PKS).
>
> Is there any feedback on this series?

Please disregard this series... (If you have not done so already).

Along with Rick posting his RFC for page table protections[1] he has raised a
concern with me about pkeys being allocated and then reallocated to another
user. It turns out the code has a bug in this area and the fix is not trivial.

Because the PMEM use case never needed to free its key and even if it did a
small window of access was not a concern this was not tested.

The best solutions involve changing the API therefore this series is going to
need a respin.

Thank you,
Ira

[1] https://lore.kernel.org/lkml/20210505003032.489164-1-rick.p.edgecombe@intel.com/

\
 
 \ /
  Last update: 2021-05-14 22:23    [W:0.072 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site