Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 14 May 2021 22:04:51 +0200 | Subject | Re: [PATCH] platform/surface: aggregator: shut up clang -Wconstantn-conversion warning |
| |
On Fri, May 14, 2021 at 9:41 PM Hans de Goede <hdegoede@redhat.com> wrote: > On 5/14/21 9:38 PM, Hans de Goede wrote: > > On 5/14/21 4:21 PM, Maximilian Luz wrote: > >> On 5/14/21 4:05 PM, Arnd Bergmann wrote: > >>> From: Arnd Bergmann <arnd@arndb.de> > >>> > >>> The assignment doesn't actually happen, but clang checks the type limits > >>> before checking whether this assignment is reached. Shut up the warning > >>> using an explicit type cast. > >> > >> I'm not too happy about this fix as (I believe) it will also shut up any > >> valid GCC error message in case those macros are used with non-u8 (and > >> non-SSAM_ANY_xxx) values. > > > > Since you're the maintainer of this code, I'll go with your judgement here,
Thanks for taking a careful look. After a little experimentation I managed to come up with a different workaround that avoids the cast.
> I just went to patchwork to drop this patch from the queue: > > https://patchwork.kernel.org/projecat/platform-driver-x86/list/ > > But it never got added there because platform-driver-x86@vger.kernel.org > was missing from the Cc even though get_maintainer.pl lists it.
I checked this as well now: the entries for the various surface drivers all contain a reference to platform-driver-x86@vger.kernel.org, but (at least in v5.13-rc1) the entry for that subsystem that lists the include file does not list this email.
Sending v2 to the list now.
Arnd
| |