Messages in this thread | | | Subject | Re: [PATCH v2 07/10] thunderbolt: test: Remove sone casts which are no longer required | From | Shuah Khan <> | Date | Fri, 14 May 2021 13:57:20 -0600 |
| |
On 5/14/21 1:27 AM, David Gow wrote: > On Fri, May 14, 2021 at 2:08 PM Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: >> >> Hi, >> >> On Thu, May 13, 2021 at 12:32:01PM -0700, David Gow wrote: >>> With some of the stricter type checking in KUnit's EXPECT macros >>> removed, several casts in the thunderbolt KUnit tests are no longer >>> required. >>> >>> Remove the unnecessary casts, making the conditions clearer. >>> >>> Signed-off-by: David Gow <davidgow@google.com> >> >> Looks good. >> >> Does this go through KUnit tree or you want me to take it? In case of >> the former feel free to add: >> >> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> >> > > Thanks. I think it's probably easier for this to go in via the KUnit > tree, unless Brendan or Shuah have any objections. >
It is fine either way unless there are dependencies on the KUnit tree. I can take this in through KUnit once Brendan looks at it.
thanks, -- Shuah
| |