| From | Linus Torvalds <> | Date | Fri, 14 May 2021 12:14:02 -0700 | Subject | Re: [GIT PULL] siginfo: ABI fixes for v5.13-rc2 |
| |
On Thu, May 13, 2021 at 9:55 PM Eric W. Biederman <ebiederm@xmission.com> wrote: > > Please pull the for-v5.13-rc2 branch from the git tree:
I really don't like this tree.
The immediate cause for "no" is the silly
#if IS_ENABLED(CONFIG_SPARC)
and
#if IS_ENABLED(CONFIG_ALPHA)
code in kernel/signal.c. It has absolutely zero business being there, when those architectures have a perfectly fine arch/*/kernel/signal.c file where that code would make much more sense *WITHOUT* any odd preprocessor games.
But there are other oddities too, like the new
send_sig_fault_trapno(SIGFPE, si_code, (void __user *) regs->pc, 0, current);
in the alpha code, which fundamentally seems bogus: using send_sig_fault_trapno() with a '0' for trapno seems entirely incorrect, since the *ONLY* point of that function is to set si_trapno to something non-zero.
So it would seem that a plain send_sig_fault() without that 0 would be the right thing to do.
This also mixes in a lot of other stuff than just the fixes. Which would have been ok during the merge window, but I'm definitely not happy about it now.
Linus
|