lkml.org 
[lkml]   [2021]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] serial: kgdb_nmi: remove redundant initialization of variable c
From
Date
On 14. 05. 21, 1:02, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable c is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
> drivers/tty/serial/kgdb_nmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
> index db059b66438e..7e07ee915f3f 100644
> --- a/drivers/tty/serial/kgdb_nmi.c
> +++ b/drivers/tty/serial/kgdb_nmi.c
> @@ -115,7 +115,7 @@ static void kgdb_tty_recv(int ch)
> static int kgdb_nmi_poll_one_knock(void)
> {
> static int n;
> - int c = -1;
> + int c;
> const char *magic = kgdb_nmi_magic;
> size_t m = strlen(magic);
> bool printch = false;
>


--
js
suse labs

\
 
 \ /
  Last update: 2021-05-14 08:52    [W:0.041 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site