Messages in this thread | | | From | Logan Gunthorpe <> | Date | Fri, 14 May 2021 10:15:44 -0600 | Subject | Re: [PATCH v2 08/22] dma-mapping: Allow map_sg() ops to return negative error codes |
| |
On 2021-05-14 7:51 a.m., Christoph Hellwig wrote: >> +int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, int nents, >> enum dma_data_direction dir, unsigned long attrs); > > I don't think it makes sense to expose this __dma_map_sg_attrs helper. > Just keep it static and move the sgtable helper to kernel/dma/mapping.c > as well.
Makes sense. I'll fix this for v3.
Logan
| |