Messages in this thread | | | Subject | Re: [PATCH v2 4/5] dt-bindings: soc: rockchip: grf: add compatible for RK3308 USB grf | From | Johan Jonker <> | Date | Fri, 14 May 2021 17:53:52 +0200 |
| |
Hi Tobias,
The grf serie is currently still under review. So things can change. Must add a change log below a "---" in the commit message for rob+dt. Maybe add a patch that fixes the reg size of "rockchip,rk3308-grf" as well?
Johan
On 5/14/21 5:00 PM, Tobias Schramm wrote: > The RK3308 has a USB GRF. > This patch adds a compatible string for it. > > Signed-off-by: Tobias Schramm <t.schramm@manjaro.org> > --- > Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 84bdaf88d5a6..df77bd2e6752 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > @@ -30,6 +30,7 @@ properties: > - rockchip,rk3288-grf > - rockchip,rk3308-core-grf > - rockchip,rk3308-detect-grf
> + - rockchip,rk3308-usb2phy-grf > - rockchip,rk3308-grf
Sort alphabetically.
> - rockchip,rk3328-grf > - rockchip,rk3328-usb2phy-grf >
Also allow usb2-phy as sub nodes name.
+ - if: + properties: + compatible: + contains: + enum: + - rockchip,px30-usb2phy-grf + - rockchip,rk3228-grf
- rockchip,rk3308-usb2phy-grf
+ - rockchip,rk3328-usb2phy-grf + - rockchip,rk3399-grf + - rockchip,rv1108-grf + + then: + required: + - "#address-cells" + - "#size-cells" + + patternProperties: + "usb2-phy@[0-9a-f]+$": + type: object + + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" + + unevaluatedProperties: false
=== Heiko's sort rules:
compatible reg interrupts [alphabetical] status [if needed]
===
Sort #phy-cells below interrupt-names.
+ #phy-cells = <0>; + interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "linestate";
| |