lkml.org 
[lkml]   [2021]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: greybus: fix gb_loopback_stats_attrs definition
    On Fri, May 14, 2021 at 07:00:39PM +0530, Shreyansh Chouhan wrote:
    > The gb_loopback_stats_attrs macro, (defined in loopback.c,) is a
    > multiline macro whose statements were not enclosed in a do while
    > loop.
    >
    > This patch adds a do while loop around the statements of the said
    > macro.
    >
    > Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
    > ---
    > drivers/staging/greybus/loopback.c | 10 ++++++----
    > 1 file changed, 6 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
    > index 2471448ba42a..c88ef3e894fa 100644
    > --- a/drivers/staging/greybus/loopback.c
    > +++ b/drivers/staging/greybus/loopback.c
    > @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \
    > } \
    > static DEVICE_ATTR_RO(name##_avg)
    >
    > -#define gb_loopback_stats_attrs(field) \
    > - gb_loopback_ro_stats_attr(field, min, u); \
    > - gb_loopback_ro_stats_attr(field, max, u); \
    > - gb_loopback_ro_avg_attr(field)
    > +#define gb_loopback_stats_attrs(field) \
    > + do { \
    > + gb_loopback_ro_stats_attr(field, min, u); \
    > + gb_loopback_ro_stats_attr(field, max, u); \
    > + gb_loopback_ro_avg_attr(field); \
    > + } while (0)
    >
    > #define gb_loopback_attr(field, type) \
    > static ssize_t field##_show(struct device *dev, \
    > --
    > 2.31.1
    >
    >

    Did you test build this change?

    \
     
     \ /
      Last update: 2021-05-14 15:36    [W:5.200 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site