Messages in this thread | | | Date | Fri, 14 May 2021 13:47:15 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC 1/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats |
| |
On Thu, May 13, 2021 at 05:56:14PM +0530, kajoljain wrote:
> But yes the current read/add/del functions are not adding value. We > could add an arch/platform specific function which could handle the > capturing of the counter data and do the rest of the operation here, > is this approach better?
Right; have your register_nvdimm_pmu() set pmu->{add,del,read} to nd_pmu->{add,del,read} directly, don't bother with these intermediates. Also you can WARN_ON_ONCE() if any of them are NULL and fail registration at that point.
| |