Messages in this thread | | | Date | Fri, 14 May 2021 11:17:41 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH 05/33] locking/atomic: openrisc: avoid asm-generic/atomic.h |
| |
On Fri, May 14, 2021 at 06:44:25AM +0900, Stafford Horne wrote: > On Mon, May 10, 2021 at 10:37:25AM +0100, Mark Rutland wrote: > > OpenRISC is the only architecture which uses asm-generic/atomic.h and > > also provides its own implementation of some functions, requiring > > ifdeferry in the asm-generic header. As OpenRISC provides the vast > > majority of functions itself, it would be simpler overall if it also > > provided the few functions it cribs from asm-generic. > > > > This patch decouples OpenRISC from asm-generic/atomic.h. Subsequent > > patches will simplify the asm-generic implementation. > > This is fine, but just a thought. If OpenRISC is the only architecture to do > this then after this patch could we remove the ifndefs from > asm-generic/atomic.h as additional cleanup?
Yup! That's done in patch 8. :)
I'll expand the wording in this commit message to explicitly mention that subsequent patches will remove the ifdeferry, rather than just simplfying the asm-generic implementation.
[...]
> Acked-by: Stafford Horne <shorne@gmail.com>
Thanks!
Mark.
| |