Messages in this thread | | | Date | Fri, 14 May 2021 11:03:01 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/2] perf tests: Drop __maybe_unused on x86 test declarations |
| |
On Thu, May 13, 2021 at 12:46:14PM -0500, Rob Herring wrote: > Function declarations don't need __maybe_unused annotations, only the > implementations do. Drop them on the perf x86 tests.
for both patches:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Jiri Olsa <jolsa@redhat.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: linux-perf-users@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > tools/perf/arch/x86/include/arch-tests.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h > index 462546bfc5f7..9599e7a3f1af 100644 > --- a/tools/perf/arch/x86/include/arch-tests.h > +++ b/tools/perf/arch/x86/include/arch-tests.h > @@ -2,12 +2,11 @@ > #ifndef ARCH_TESTS_H > #define ARCH_TESTS_H > > -#include <linux/compiler.h> > struct test; > > /* Tests */ > -int test__rdpmc(struct test *test __maybe_unused, int subtest); > -int test__insn_x86(struct test *test __maybe_unused, int subtest); > +int test__rdpmc(struct test *test, int subtest); > +int test__insn_x86(struct test *test, int subtest); > int test__intel_pt_pkt_decoder(struct test *test, int subtest); > int test__bp_modify(struct test *test, int subtest); > int test__x86_sample_parsing(struct test *test, int subtest); > -- > 2.27.0 >
| |