lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 169/244] drivers/block/null_blk/main: Fix a double free in null_init.
    Date
    From: Lv Yunlong <lyl2019@mail.ustc.edu.cn>

    [ Upstream commit 72ce11ddfa4e9e1879103581a60b7e34547eaa0a ]

    In null_init, null_add_dev(dev) is called.
    In null_add_dev, it calls null_free_zoned_dev(dev) to free dev->zones
    via kvfree(dev->zones) in out_cleanup_zone branch and returns err.
    Then null_init accept the err code and then calls null_free_dev(dev).

    But in null_free_dev(dev), dev->zones is freed again by
    null_free_zoned_dev().

    My patch set dev->zones to NULL in null_free_zoned_dev() after
    kvfree(dev->zones) is called, to avoid the double free.

    Fixes: 2984c8684f962 ("nullb: factor disk parameters")
    Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
    Link: https://lore.kernel.org/r/20210426143229.7374-1-lyl2019@mail.ustc.edu.cn
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/block/null_blk_zoned.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/block/null_blk_zoned.c b/drivers/block/null_blk_zoned.c
    index 5f1376578ea3..90dcf4a915f4 100644
    --- a/drivers/block/null_blk_zoned.c
    +++ b/drivers/block/null_blk_zoned.c
    @@ -73,6 +73,7 @@ int null_zone_init(struct nullb_device *dev)
    void null_zone_exit(struct nullb_device *dev)
    {
    kvfree(dev->zones);
    + dev->zones = NULL;
    }

    int null_zone_report(struct gendisk *disk, sector_t sector,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 17:10    [W:4.093 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site