lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 114/244] crypto: qat - Fix a double free in adf_create_ring
    Date
    From: Lv Yunlong <lyl2019@mail.ustc.edu.cn>

    [ Upstream commit f7cae626cabb3350b23722b78fe34dd7a615ca04 ]

    In adf_create_ring, if the callee adf_init_ring() failed, the callee will
    free the ring->base_addr by dma_free_coherent() and return -EFAULT. Then
    adf_create_ring will goto err and the ring->base_addr will be freed again
    in adf_cleanup_ring().

    My patch sets ring->base_addr to NULL after the first freed to avoid the
    double free.

    Fixes: a672a9dc872ec ("crypto: qat - Intel(R) QAT transport code")
    Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/qat/qat_common/adf_transport.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
    index 2136cbe4bf6c..f65ebc4117d1 100644
    --- a/drivers/crypto/qat/qat_common/adf_transport.c
    +++ b/drivers/crypto/qat/qat_common/adf_transport.c
    @@ -197,6 +197,7 @@ static int adf_init_ring(struct adf_etr_ring_data *ring)
    dev_err(&GET_DEV(accel_dev), "Ring address not aligned\n");
    dma_free_coherent(&GET_DEV(accel_dev), ring_size_bytes,
    ring->base_addr, ring->dma_addr);
    + ring->base_addr = NULL;
    return -EFAULT;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 17:05    [W:4.079 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site