lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 068/244] ARM: dts: exynos: correct PMIC interrupt trigger level on Midas family
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit e52dcd6e70fab51f53292e53336ecb007bb60889 ]

    The Maxim PMIC datasheets describe the interrupt line as active low
    with a requirement of acknowledge from the CPU. Without specifying the
    interrupt type in Devicetree, kernel might apply some fixed
    configuration, not necessarily working for this hardware.

    Additionally, the interrupt line is shared so using level sensitive
    interrupt is here especially important to avoid races.

    Fixes: 15dfdfad2d4a ("ARM: dts: Add basic dts for Exynos4412-based Trats 2 board")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20201210212534.216197-5-krzk@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
    index 79e6bd56f9ad..fedb21377c66 100644
    --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
    +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
    @@ -588,7 +588,7 @@
    max77686: max77686_pmic@9 {
    compatible = "maxim,max77686";
    interrupt-parent = <&gpx0>;
    - interrupts = <7 IRQ_TYPE_NONE>;
    + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
    pinctrl-0 = <&max77686_irq>;
    pinctrl-names = "default";
    reg = <0x09>;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 16:58    [W:3.566 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site