Messages in this thread | | | Date | Wed, 12 May 2021 14:59:55 +0100 | From | Qais Yousef <> | Subject | Re: [PATCH] sched/fair: Rate limit calls to update_blocked_averages() for NOHZ |
| |
On 05/11/21 10:25, Tim Chen wrote: > > update_next_balance() is only used in newidle_balance() so we could > > modify it to have: > > > > next = max(jiffies+1, next = sd->last_balance + interval) > > Is the extra assignment "next = sd->last_balance + interval" needed? > This seems more straight forward: > > next = max(jiffies+1, sd->last_balance + interval)
I haven't been following the whole conversation closely, but it's always interesting when manipulating time in non time_*() functions.
Is this max() safe against wrapping?
Thanks
-- Qais Yousef
| |