lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/2] scsi: ufs: Introduce hba performance monitor sysfs nodes
From
Date
On Wed, 2021-04-21 at 19:28 -0700, Can Guo wrote:
> +
>
> +static DEVICE_ATTR_RW(monitor_enable);
>
> +static DEVICE_ATTR_RW(monitor_chunk_size);
>
> +static DEVICE_ATTR_RO(read_total_sectors);
>
> +static DEVICE_ATTR_RO(read_total_busy);
>
> +static DEVICE_ATTR_RO(read_nr_requests);
>
> +static DEVICE_ATTR_RO(read_req_latency_avg);
>
> +static DEVICE_ATTR_RO(read_req_latency_max);
>
> +static DEVICE_ATTR_RO(read_req_latency_min);
>
> +static DEVICE_ATTR_RO(read_req_latency_sum);
>
> +static DEVICE_ATTR_RO(write_total_sectors);
>
> +static DEVICE_ATTR_RO(write_total_busy);
>
> +static DEVICE_ATTR_RO(write_nr_requests);
>
> +static DEVICE_ATTR_RO(write_req_latency_avg);
>
> +static DEVICE_ATTR_RO(write_req_latency_max);
>
> +static DEVICE_ATTR_RO(write_req_latency_min);
>
> +static DEVICE_ATTR_RO(write_req_latency_sum);

Can,

I like this series of patches, which can help me monitor UFS
performance online. I have a suggestion, how do you think that we add
this to ufs-debugfs. Then we don't need to poll each parameter one by
one, just one interface.

Bean

\
 
 \ /
  Last update: 2021-05-12 23:32    [W:0.399 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site