lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH rdma-next] RDMA/rdmavt: Decouple QP and SGE lists allocations
From
Date

On 5/11/21 3:27 PM, Leon Romanovsky wrote:
> On Tue, May 11, 2021 at 07:15:09PM +0000, Marciniszyn, Mike wrote:
>>>>
>>>> Why not kzalloc_node() here?
>>
>> I agree here.
>>
>> Other allocations that have been promoted to the core have lost the node attribute in the allocation.
>
> Did you notice any performance degradation?
>

So what's the motivation to change it from the way it was originally
designed? It seems to me if the original implementation went to the
trouble to allocate the memory on the local node, refactoring the code
should respect that.

-Denny

\
 
 \ /
  Last update: 2021-05-12 06:09    [W:0.115 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site