lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 488/530] ath10k: Fix ath10k_wmi_tlv_op_pull_peer_stats_info() unlock without lock
    Date
    From: Shuah Khan <skhan@linuxfoundation.org>

    [ Upstream commit eaaf52e4b866f265eb791897d622961293fd48c1 ]

    ath10k_wmi_tlv_op_pull_peer_stats_info() could try to unlock RCU lock
    winthout locking it first when peer reason doesn't match the valid
    cases for this function.

    Add a default case to return without unlocking.

    Fixes: 09078368d516 ("ath10k: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()")
    Reported-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20210406230228.31301-1-skhan@linuxfoundation.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/wmi-tlv.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
    index e7072fc4f487..4f2fbc610d79 100644
    --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
    +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
    @@ -592,6 +592,9 @@ static void ath10k_wmi_event_tdls_peer(struct ath10k *ar, struct sk_buff *skb)
    GFP_ATOMIC
    );
    break;
    + default:
    + kfree(tb);
    + return;
    }

    exit:
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 19:01    [W:4.036 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site