lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 330/530] scsi: ufs: ufshcd-pltfrm: Fix deferred probing
    Date
    From: Sergey Shtylyov <s.shtylyov@omprussia.ru>

    [ Upstream commit 339c9b63cc7ce779ce45c675bf709cb58b807fc3 ]

    The driver overrides the error codes returned by platform_get_irq() to
    -ENODEV, so if it returns -EPROBE_DEFER, the driver would fail the probe
    permanently instead of the deferred probing. Propagate the error code
    upstream as it should have been done from the start...

    Link: https://lore.kernel.org/r/420364ca-614a-45e3-4e35-0e0653c7bc53@omprussia.ru
    Fixes: 2953f850c3b8 ("[SCSI] ufs: use devres functions for ufshcd")
    Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
    index 3db0af66c71c..24927cf485b4 100644
    --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
    +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
    @@ -377,7 +377,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,

    irq = platform_get_irq(pdev, 0);
    if (irq < 0) {
    - err = -ENODEV;
    + err = irq;
    goto out;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 19:01    [W:6.272 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site