lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 413/530] mt76: mt7915: fix tx skb dma unmap
    Date
    From: Felix Fietkau <nbd@nbd.name>

    [ Upstream commit 7dcf3c04f0aca746517a77433b33d40868ca4749 ]

    The first pointer in the txp needs to be unmapped as well, otherwise it will
    leak DMA mapping entries

    Reported-by: Ben Greear <greearb@candelatech.com>
    Fixes: 27d5c528a7ca ("mt76: fix double DMA unmap of the first buffer on 7615/7915")
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    index 6f159d99a596..dd5793004989 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
    @@ -856,7 +856,7 @@ void mt7915_txp_skb_unmap(struct mt76_dev *dev,
    int i;

    txp = mt7915_txwi_to_txp(dev, t);
    - for (i = 1; i < txp->nbuf; i++)
    + for (i = 0; i < txp->nbuf; i++)
    dma_unmap_single(dev->dev, le32_to_cpu(txp->buf[i]),
    le16_to_cpu(txp->len[i]), DMA_TO_DEVICE);
    }
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 19:01    [W:3.670 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site