lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 410/530] rtw88: Fix an error code in rtw_debugfs_set_rsvd_page()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit c9eaee0c2ec6b1002044fb698cdfb5d9ef4ed28c ]

    The sscanf() function returns the number of matches (0 or 1 in this
    case). It doesn't return error codes. We should return -EINVAL if the
    string is invalid

    Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/YE8nmatMDBDDWkjq@mwanda
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
    index efbba9caef3b..8bb6cc8ca74e 100644
    --- a/drivers/net/wireless/realtek/rtw88/debug.c
    +++ b/drivers/net/wireless/realtek/rtw88/debug.c
    @@ -270,7 +270,7 @@ static ssize_t rtw_debugfs_set_rsvd_page(struct file *filp,

    if (num != 2) {
    rtw_warn(rtwdev, "invalid arguments\n");
    - return num;
    + return -EINVAL;
    }

    debugfs_priv->rsvd_page.page_offset = offset;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 19:01    [W:4.245 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site