lkml.org 
[lkml]   [2021]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 145/530] usb: typec: stusb160x: fix return value check in stusb160x_probe()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit f2d90e07b5df2c7745ae66d2d48cc350d3f1c7d2 ]

    In case of error, the function device_get_named_child_node() returns
    NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
    should be replaced with NULL test.

    Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Link: https://lore.kernel.org/r/20210308094839.3586773-1-weiyongjun1@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/typec/stusb160x.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
    index d21750bbbb44..6eaeba9b096e 100644
    --- a/drivers/usb/typec/stusb160x.c
    +++ b/drivers/usb/typec/stusb160x.c
    @@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client)
    }

    fwnode = device_get_named_child_node(chip->dev, "connector");
    - if (IS_ERR(fwnode))
    - return PTR_ERR(fwnode);
    + if (!fwnode)
    + return -ENODEV;

    /*
    * When both VDD and VSYS power supplies are present, the low power
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-12 18:02    [W:2.755 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site